Fix showing error message when guest author creation capability is removed#142
Open
dottxado wants to merge 4 commits intohumanmade:developfrom
Open
Fix showing error message when guest author creation capability is removed#142dottxado wants to merge 4 commits intohumanmade:developfrom
dottxado wants to merge 4 commits intohumanmade:developfrom
Conversation
roborourke
reviewed
Jul 25, 2024
Contributor
roborourke
left a comment
roborourke
left a comment
There was a problem hiding this comment.
Is the error response always JSON? Can probably preserve the typescript hinting at least.
The new promise chain you added might need a .catch() as well to be safe, I think it could just log to the console if it isn't JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #141