Decode URLs when parsing them from content#82
Merged
Conversation
tomjn
approved these changes
Aug 9, 2025
WordPress stores URLs in the post content as html entity encoded. Thi means in cases when there are images in the content that have query params, currently our replacements around the use of `presign` break. In all other cases `tachyon_url()` expects a clean URL, not a htmlentities applied one, so we make sure to be consistent.
joehoyle
force-pushed
the
html-decode-src
branch
from
bcc9f26 to
83ac162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress stores URLs in the post content as html entity encoded. Thi means in cases when there are images in the content that have query params, currently our replacements around the use of
presignbreak. In all other casestachyon_url()expects a clean URL, not a htmlentities applied one, so we make sure to be consistent.