Open
Conversation
|
@shadyvb Any chance of merging this? |
shadyvb
approved these changes
Dec 19, 2018
Contributor
shadyvb
left a comment
There was a problem hiding this comment.
LGTM, need to do some testing this week before merging.
Thanks @spacedmonkey !
|
Any chance this can get merged? @shadyvb |
|
Updated PR to stop fatal error. |
Fix SLS error message
Make filter more useful.
|
In Skyscanner#7 it makes the settings more filter so SLS can be filtered to pass other params to In Skyscanner#6 I fixed the error message. |
|
Hey there, was wondering if there were any plans to get this merged soon? Need this to fulfill a high priority security requirement. Thanks! |
|
@shadyvb what needs to be done to get this merged? Anything I can help out on? |
roborourke
requested changes
Jan 11, 2023
| ], | ||
| 'NameIDFormat' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress', | ||
| ]; | ||
| $settings['sp']['entityId'] = $sp_home_url; |
Contributor
There was a problem hiding this comment.
This doesn't guarantee $settings['sp'] is set any more.
Suggested change
| $settings['sp']['entityId'] = $sp_home_url; | |
| if ( ! isset( $settings['sp'] ) { | |
| $settings['sp'] = []; | |
| } | |
| $settings['sp']['entityId'] = $sp_home_url; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5. Thoe workflow is are as follows:
sso/slsendpoint./wp-adminsso/slsendpoint with a redirect.