Skip to content

Fix escrow payouts#3261

Merged
flopez7 merged 7 commits intofeat/escrow-cancellationfrom
fix/escrow-payouts
May 21, 2025
Merged

Fix escrow payouts#3261
flopez7 merged 7 commits intofeat/escrow-cancellationfrom
fix/escrow-payouts

Conversation

@portuu3
Copy link
Copy Markdown
Collaborator

@portuu3 portuu3 commented Apr 3, 2025

Issue tracking

NA

Context behind the change

  • In some escrows balance and remainingFunds is missmatching. It was due to decimals being truncated when oracle fees are calculated. With this fix truncated amount is paid to workers.
  • Tests improvements.
  • Document the contract with comments.
  • Use faker library at full monorepo level.

How has this been tested?

With unit tests

Release plan

Upgrade escrow factory contracts

Potential risks; What to monitor; Rollback plan

  • Possible issues upgrading the contracts

@portuu3 portuu3 added the bug Something isn't working label Apr 3, 2025
@portuu3 portuu3 self-assigned this Apr 3, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ❌ Failed (Inspect) May 21, 2025 11:57am
human-dashboard-frontend ❌ Failed (Inspect) May 21, 2025 11:57am
staking-dashboard ❌ Failed (Inspect) May 21, 2025 11:57am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 11:57am
faucet-server ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 11:57am

@portuu3 portuu3 force-pushed the fix/escrow-payouts branch from a8710ad to dd712c2 Compare May 21, 2025 08:40
@portuu3 portuu3 changed the base branch from feat/escrow-cancellation to develop May 21, 2025 08:40
@portuu3 portuu3 changed the base branch from develop to feat/escrow-cancellation May 21, 2025 08:44
@flopez7 flopez7 changed the base branch from feat/escrow-cancellation to develop May 21, 2025 09:08
@flopez7 flopez7 changed the base branch from develop to feat/escrow-cancellation May 21, 2025 09:09
@flopez7 flopez7 force-pushed the feat/escrow-cancellation branch 2 times, most recently from 3f4dce8 to 941d544 Compare May 21, 2025 09:19
@flopez7 flopez7 merged commit ee21c4d into feat/escrow-cancellation May 21, 2025
5 of 21 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Core-tech - 2025 May 21, 2025
@portuu3 portuu3 deleted the fix/escrow-payouts branch May 21, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants