feat: use cache for node js github actions#3316
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
12 tasks
Dzeranov
approved these changes
May 5, 2025
1 task
flopez7
pushed a commit
that referenced
this pull request
May 21, 2025
* feat: use cache for node js github actions * feat: run js lint only when js app changes * chore: trigger ga * chore: trigger ga [2] * fix: ci lint config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
Part of #2803
Context behind the change
Right now GA wastes a lot of time on installing Node.js packages in monorepo because no caching is used. Changing
setup-nodeaction to use default caching strategy foryarn, which is based onyarn.lockfile.Also added
branchespatterns toprandpushtriggers because there is no need to run actions for every pull request.Important
After adding cache for
yarndependencies are fetched using it, butyarnhas another step -Linking dependencies- which is very slow for the version we use and workspaces. In order to address it - we might want to updateyarnHow has this been tested?
Release plan
Simply merge
Potential risks; What to monitor; Rollback plan
Should be none