Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
portuu3
left a comment
portuu3
left a comment
There was a problem hiding this comment.
For bulkPayout we should have the changes from https://github.com/humanprotocol/human-protocol/pull/3261/files. Merge it first
|
For bulkPayout we should have the changes from https://github.com/humanprotocol/human-protocol/pull/3261/files. Merge it first |
* Fix possible no assignments error when there are * Update readme * Update cvat sdk versions * Address api changes * Improve performance of some cvat calls * Improve description
* Draw roi point along with bbox in skeleton tasks * Relax filtering for overlapping gt skeletons (#3358)
flopez7
force-pushed
the
feat/escrow-cancellation
branch
from
3ac3fbb to
3f4dce8
Compare
flopez7
force-pushed
the
feat/escrow-cancellation
branch
from
3f4dce8 to
941d544
Compare
…otocol/human-protocol into feat/escrow-cancellation
* fix payouts when fee calculation is truncated * fix tests and use faker in the root of the repository * document escrow contract and improve tests * Delete unnecessary check for BULK_MAX_VALUE * remove unused modifier * Undo faker package changes for updating yarn --------- Co-authored-by: Francisco López <francislopez977@gmail.com>
…avoid remaining funds and update tests for dynamic amounts
| await this.jobService.resumeJob(webhook); | ||
| break; | ||
|
|
||
| case EventType.ESCROW_CANCELED: |
There was a problem hiding this comment.
I think we can delete this event type, we are not using it
There was a problem hiding this comment.
I added it to avoid returning error in case ESCROW_CANCELED type is received.
| public async processEscrowCancellation( | ||
| jobEntity: JobEntity, | ||
| ): Promise<EscrowCancelDto> { | ||
| public async processEscrowCancellation(jobEntity: JobEntity): Promise<void> { |
There was a problem hiding this comment.
return is unnecessary here
| status == EscrowStatuses.ToCancel, | ||
| 'Escrow not in Pending, Partial or ToCancel status state' | ||
| ); | ||
| if (_fundsToReserve != 0) { |
There was a problem hiding this comment.
why only url and hash are required if _fundsToReserve != 0, in any case I think it should _fundsToReserve > 0
There was a problem hiding this comment.
Since _fundsToReserve is a uint256, both conditions (!= 0 and > 0) are equivalent.
I used this condition to allow canceling escrows when no solutions are received; in those cases, we don't have any URL or hash, so we must allow those fields to be empty.
That's why the check is only enforced when _fundsToReserve is not zero.
…s for status, balance, and cancellation
|
Changes applied in #3482 |
3 participants
Issue tracking
#3287
Context behind the change
How has this been tested?
Deployed locally and completed the fortune flow with some escrows. Tested normal and cancellation flow
Run unit tests
Release plan
Important: Check that there are no active escrows before deployment to avoid errors due to StoreResult contract change. Also we need to make sure CVAT and Audino are updated to use new contract version
Potential risks; What to monitor; Reverse plan
Since the core has been updated, we have to check each step to make sure it works correctly.