Conversation
…RESS escrows and update createCompletedEvent fixture to include timestamp
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
portuu3
approved these changes
Jun 24, 2025
This was referenced Jun 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3401
Context behind the change
Improve handleCompleted to create InternalTransaction and reset escrow balance when transferring funds on completion.
How has this been tested?
Created new tests for it and ran it
Release plan
Deploy new subgraph version
Potential risks; What to monitor; Rollback plan
Check if escrow balance is 0 when calling complete and the escrow is not totally paid