Open
Conversation
Author
|
@humbletim can you take a look please at this one-liner |
technoir42
commented
Aug 1, 2025
| echo "recognized zip layout 'vulkan_sdk.zip' ${InstallVulkan}.app/Contents" >&2 | ||
| local sdk_temp=${VULKAN_SDK}.tmp | ||
| sudo ${InstallVulkan}.app/Contents/MacOS/${InstallVulkan} --root "$sdk_temp" --accept-licenses --default-answer --confirm-command install | ||
| sudo ${InstallVulkan}.app/Contents/MacOS/${InstallVulkan} --root "$sdk_temp" --accept-licenses --default-answer --confirm-command install com.lunarg.vulkan.volk |
Author
There was a problem hiding this comment.
humbletim
approved these changes
Aug 4, 2025
Owner
humbletim
left a comment
humbletim
left a comment
There was a problem hiding this comment.
thanks for the PR!
i want to run a few more tests to confirm specifying optional components this way doesn't inadvertently reduce default component selections -- but otherwise including volk this way seems reasonable enough to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volk is an optional component on macOS, whereas on Windows and Linux it's installed by default.
Since it's tiny, I'd just install it by default for parity between OS.