Minor fixes to run some of your codes#3
Open
yoshitomo-matsubara wants to merge 6 commits intohuminghao16:masterfrom
Open
Minor fixes to run some of your codes#3yoshitomo-matsubara wants to merge 6 commits intohuminghao16:masterfrom
yoshitomo-matsubara wants to merge 6 commits intohuminghao16:masterfrom
Conversation
|
Hey there @yoshitomo-matsubara that's a great work! it would be very helpful if you could upload the trained models. |
This was referenced Jul 11, 2019
Author
Hi @Arjunsankarlal Hi @huminghao16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First of all, thank you for sharing your code!
I tried to reproduce results in your paper, and found there are two different "data" folders (one at user home, one at the same level of src folder), which caused some errors like FileNotFoundError
With my minor fixes (including README.md) and the following scripts, there will be only one data folder (at the same level of src folder), and we can complete tasks for SQuAD-doc, TriviaQA-wiki, and TriviaQA-open.
Note: At first I tried to set 32 at train_batch_size for both models as suggested, but faced CUDA out of memory error even with 4 GPUs (each of them has 16GB video memory), so used 16 as train_batch_size
Regardless of my minor fixes, I faced a different error for SQuAD-open, but couldn't fix it shortly.
I will submit issues with some additional questions, and put the links here later.
Thank you!