refactor: reduce CLI complexity + vulture whitelist (97→98 A)#1
Closed
hummbl-dev wants to merge 1 commit intomainfrom
Closed
refactor: reduce CLI complexity + vulture whitelist (97→98 A)#1hummbl-dev wants to merge 1 commit intomainfrom
hummbl-dev wants to merge 1 commit intomainfrom
Conversation
Extract helpers from 4 high-CC CLI handlers in __main__.py: - cmd_analyze: _parse_exclude, _persist_file_quality, _score_commits, _print_analyze_summary - cmd_triage: _classify_repo, _print_triage - cmd_fix: _run_ruff_fix, _print_fix_delta - Fix E701 one-liners in _print_fleet_report Add vulture_whitelist.py for known false positives (HTTP handler overrides, public API methods, dataclass fields). Dead code analyzer now auto-detects vulture_whitelist.py in repo root. Score: 62.1 (D) → 98.0 (A) | Complexity: 6→3 findings | Vulture: 91→0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Closing — conflicts with #2 (report generator) which included overlapping CLI changes. Complexity reduction already landed via hummbl-agent Arbiter quality push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract helpers from 4 high-CC CLI handlers to reduce cyclomatic complexity. Add vulture whitelist for false-positive dead code findings.
Changes
__main__.py: Extract 8 helpers fromcmd_analyze,cmd_triage,cmd_fixdead_code_analyzer.py: Auto-detectvulture_whitelist.pyin repo rootvulture_whitelist.py: Known false positives (HTTP overrides, public API, dataclass fields)Score Impact
Test plan
🤖 Generated with Claude Code