Fix score_connection not extracting maximum frame in overlapping case 2 when in training mode#96
Open
althonos wants to merge 1 commit intohyattpd:GoogleImportfrom
Open
Fix score_connection not extracting maximum frame in overlapping case 2 when in training mode#96althonos wants to merge 1 commit intohyattpd:GoogleImportfrom
score_connection not extracting maximum frame in overlapping case 2 when in training mode#96althonos wants to merge 1 commit intohyattpd:GoogleImportfrom
Conversation
…se 2 when in training mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again!
While refactoring the Pyrodigal code thanks to @jhahnfeld and @oschwengers, I noticed that the part of the
score_connectionfunction that is supposed to extract the frame with the maximum score was not actually extracting the maximum one while in training mode. This can change the predictions, for instance onGCF_000067165the fixes causes a gene to start 160bp before what Prodigal actually predicts.I'm not actually sure whether this is intended, but if it's not, here is a bugfix.