fix: sanitize preview IDs to prevent path traversal and XSS#11
Merged
Conversation
… (security) Preview routes accepted unsanitized :id params from the URL, allowing path traversal (../../) to read/write/delete .json files outside the previews directory, and reflected XSS via the 404 page. Added assertSinglePathSegment() validation to all four :id route handlers and escapeHtml() to the 404 response. Both guards already existed in src/utils/security.ts. Bump to v0.62.10.
assertSinglePathSegment already blocks traversal, but CodeQL cannot trace that validation. Adding resolvePathWithinRoot as a second guard in previewPath() itself makes the path restriction visible to static analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:idparams, allowing path traversal (../../) to read/write/delete.jsonfiles outside the previews directoryassertSinglePathSegment()to all four:idroute handlers (PUT, GET, GET /meta, DELETE)escapeHtml()to the 404 response as defense-in-depthsrc/utils/security.ts, just weren't wired up for preview routesTest plan
../../api-token) return "Invalid preview ID"