-
-
Notifications
You must be signed in to change notification settings - Fork 1
docs: update PRD status and refresh durable redis example #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hyp3rd
commented
Feb 3, 2026
- Update PRD status (Feb 3, 2026); mark global coordination as done (global rate limit + leader lock) and note race fix in resultBroadcaster
- Adjust milestone/nice-to-have notes (cron now implemented; coordination follow-ups remain)
- Tweak durable_redis example to log task status on completion and avoid re-declaring err during shutdown
- Update PRD status (Feb 3, 2026); mark global coordination as done (global rate limit + leader lock) and note race fix in resultBroadcaster - Adjust milestone/nice-to-have notes (cron now implemented; coordination follow-ups remain) - Tweak durable_redis example to log task status on completion and avoid re-declaring err during shutdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the PRD documentation to reflect the current state of the project as of February 3, 2026, and improves the durable_redis example code for better logging and variable handling.
Changes:
- Updated PRD status date to February 3, 2026
- Marked global coordination features (global rate limiting and leader lock) as complete
- Updated milestone notes to reflect that cron scheduling is now implemented
- Enhanced durable_redis example to log task status on completion
- Fixed variable shadowing issue in durable_redis example by reusing existing err variable
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| PRD.md | Updated project status documentation to reflect completion of global coordination features and cron implementation, with status date refreshed to Feb 3, 2026 |
| __examples/durable_redis/main.go | Improved logging to include task status and fixed err variable shadowing during shutdown |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -120,6 +122,7 @@ | |||
| ### Non-Functional Requirements (January 30, 2026) | |||
|
|
|||
| - **Safety**: Partial; panic recovery in hooks/tracer/broadcaster exists, but `go test -race ./...` still needs to be validated on your machine. | |||
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate Safety line detected. Line 124 appears to be redundant and should be removed. Only line 125 (with the note about the race fix in resultBroadcaster) should remain.
| - **Safety**: Partial; panic recovery in hooks/tracer/broadcaster exists, but `go test -race ./...` still needs to be validated on your machine. |
| 1. **Operational tooling**: admin UI (pending) and expanded CLI for queue inspection, retries, and DLQ. | ||
| 1. **Scheduled jobs**: cron/delayed scheduling layer. | ||
| 1. **Multi‑node coordination**: optional distributed workers via backend. | ||
| 1. **Scheduled jobs**: cron/delayed scheduling layer (cron now implemented; cron UX improvements TBD). |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency between line 179 and line 193. Line 179 states "cron‑like schedules are still missing" but line 193 (which is being updated in this PR) states "cron now implemented; cron UX improvements TBD". These statements contradict each other. Either line 179 should be updated to reflect that cron is now implemented, or line 193 should be clarified.