Improve search error isolation #1175
Conversation
🦋 Changeset detectedLatest commit: 0db3aa2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandon-pereira
requested review from
a team and
knudtty
and removed request for
a team
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🔴 Failure (1/4 tests failed) [dashboard] Failed Tests: This comment was generated from stably-runner-action |
|
Hmm is there any way we could make the error expandable? Something like this but an icon and gray 
|
@knudtty before it was scrollable, but definitely not the best UX. I've improved this to now open in modal. I was originally going to do an 
|
|
@brandon-pereira for the |
E2E Test Results❌ 1 test failed • 14 passed • 3 skipped • 214s
|
improve search results to isolate graph query errors to the graph component
Before (if graph throws error, whole page shows error):
After (error is isolated so results still work):
This was original tweaked in #693, but if the search page errors, the desired output is still achieved:
Also snuck in a fix where the Event Deltas results could not be scrolled if your screen is too small, now you can see all the data (through scrolling):
Fixes: HDX-2398