fix: json getKeyValues (useful for autocomplete) #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f8a9a1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🔴 Failure (1/4 tests failed) [dashboard] Failed Tests: This comment was generated from stably-runner-action |
MikeShi42
reviewed
Sep 19, 2025
| ); | ||
| const searchKeys = useMemo( | ||
| () => (searchField ? [mergePath(searchField.path, jsonColumns)] : []), | ||
| () => (searchField ? [mergePath(searchField.path, jsonColumns ?? [])] : []), |
There was a problem hiding this comment.
I think we want to skip calling mergePath unless we have jsonColumns loaded right? Otherwise we might mistakenly treat JSON columns as non-JSON due to a race condition with loading the JSON column list.
There was a problem hiding this comment.
Hmm that's a good call! updated
MikeShi42
approved these changes
Sep 19, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
) This reverts commit d60d920. Commit breaks dashboards with: <img width="1179" height="779" alt="image" src="https://github.com/user-attachments/assets/bcb05f7a-6787-4a39-859f-92e6f6ffbe9e" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref HDX-2034