-
Notifications
You must be signed in to change notification settings - Fork 253
Add ingestion key check to otel collector via OpAMP #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
allowed_headers: ['*'] | ||
include_metadata: true | ||
endpoint: '0.0.0.0:4318' | ||
# otlp/hyperdx: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to opampController
, this is so we don't enable these receivers until we know for sure which authentication mode we want
@@ -57,7 +62,9 @@ services: | |||
- internal | |||
healthcheck: | |||
# "clickhouse", "client", "-u ${CLICKHOUSE_USER}", "--password ${CLICKHOUSE_PASSWORD}", "-q 'SELECT 1'" | |||
test: wget --no-verbose --tries=1 http://127.0.0.1:8123/ping || exit 1 | |||
test: | |||
wget -O /dev/null --no-verbose --tries=1 http://127.0.0.1:8123/ping || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes failing healthcheck (dev issue)
@@ -32,8 +33,10 @@ processors: | |||
statements: | |||
# JSON parsing: Extends log attributes with the fields from structured log body content, either as an OTEL map or | |||
# as a string containing JSON content. | |||
- set(log.cache, ExtractPatterns(log.body, "(?P<0>(\\{.*\\}))")) where IsString(log.body) | |||
- merge_maps(log.attributes, ParseJSON(log.cache["0"]), "upsert") where IsMap(log.cache) | |||
- set(log.cache, ExtractPatterns(log.body, "(?P<0>(\\{.*\\}))")) where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just prettier formatting, no changes here in transform
if (config.IS_LOCAL_APP_MODE) { | ||
return LOCAL_APP_TEAM; | ||
} | ||
|
||
return Team.findById(id, fields); | ||
return Team.findOne({}, fields); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should always only have 1 team in the collection
@@ -9,6 +9,7 @@ export interface ITeam { | |||
allowedAuthMethods?: 'password'[]; | |||
apiKey: string; | |||
hookId: string; | |||
collectorAuthenticationEnforced: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this enables collector auth moving forward, but preserves existing v2 no-auth behavior for existing deployments
HDX-1698
TODO: