Skip to content

Add ingestion key check to otel collector via OpAMP #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

MikeShi42
Copy link
Contributor

@MikeShi42 MikeShi42 commented May 17, 2025

HDX-1698

TODO:

  • Configure/Test OpAMP on all deployment modes (ci, dev, local, aio, compose, helm)
  • Check TLS settings
  • Any docs needed to securely deploy opamp (ensure config ports aren't public, etc.)
  • Changeset message
  • (Opt) Check if we need stateful AgentStore

Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: b3813ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2025 7:28pm

allowed_headers: ['*']
include_metadata: true
endpoint: '0.0.0.0:4318'
# otlp/hyperdx:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to opampController, this is so we don't enable these receivers until we know for sure which authentication mode we want

@@ -57,7 +62,9 @@ services:
- internal
healthcheck:
# "clickhouse", "client", "-u ${CLICKHOUSE_USER}", "--password ${CLICKHOUSE_PASSWORD}", "-q 'SELECT 1'"
test: wget --no-verbose --tries=1 http://127.0.0.1:8123/ping || exit 1
test:
wget -O /dev/null --no-verbose --tries=1 http://127.0.0.1:8123/ping ||
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes failing healthcheck (dev issue)

@@ -32,8 +33,10 @@ processors:
statements:
# JSON parsing: Extends log attributes with the fields from structured log body content, either as an OTEL map or
# as a string containing JSON content.
- set(log.cache, ExtractPatterns(log.body, "(?P<0>(\\{.*\\}))")) where IsString(log.body)
- merge_maps(log.attributes, ParseJSON(log.cache["0"]), "upsert") where IsMap(log.cache)
- set(log.cache, ExtractPatterns(log.body, "(?P<0>(\\{.*\\}))")) where
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just prettier formatting, no changes here in transform

if (config.IS_LOCAL_APP_MODE) {
return LOCAL_APP_TEAM;
}

return Team.findById(id, fields);
return Team.findOne({}, fields);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should always only have 1 team in the collection

@@ -9,6 +9,7 @@ export interface ITeam {
allowedAuthMethods?: 'password'[];
apiKey: string;
hookId: string;
collectorAuthenticationEnforced: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this enables collector auth moving forward, but preserves existing v2 no-auth behavior for existing deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant