Skip to content

feat: highlight selected span from results table by default in trace side panel #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

MikeShi42
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: 4aa90ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 7:25pm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the feature to highlight a selected span from the results table by default in the trace side panel. Key changes include adding an initialRowHighlightHint prop to the relevant components, passing down the hint from DBTracePanel to DBTraceWaterfallChartContainer and DBRowSidePanel, and updating DBRowDataPanel to extract the necessary timestamp and span id information.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/app/src/components/DBTraceWaterfallChart.tsx Added initialRowHighlightHint prop and associated useEffect for span highlighting in the chart.
packages/app/src/components/DBTracePanel.tsx Passed through initialRowHighlightHint to the chart container.
packages/app/src/components/DBRowSidePanel.tsx Computed initialRowHighlightHint based on normalized row data.
packages/app/src/components/DBRowDataPanel.tsx Updated timestamp and span ID extraction and display expressions.
Comments suppressed due to low confidence (1)

packages/app/src/components/DBTraceWaterfallChart.tsx:300

  • Ensure that the property names used in initialRowHighlightHint match those used in rows. If normalized row data uses keys like '__hdx_timestamp', '__hdx_span_id', and '__hdx_body', consider aligning these with the chart's property names (Timestamp, SpanId, Body) so that the comparison works as expected.
row.Timestamp === initialRowHighlightHint.timestamp && row.SpanId === initialRowHighlightHint.spanId && row.Body === initialRowHighlightHint.body

@kodiakhq kodiakhq bot merged commit cb26b31 into v2 May 19, 2025
6 of 7 checks passed
@kodiakhq kodiakhq bot deleted the mikeshi/highlight-span-by-default branch May 19, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants