-
Notifications
You must be signed in to change notification settings - Fork 253
feat: highlight selected span from results table by default in trace side panel #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the feature to highlight a selected span from the results table by default in the trace side panel. Key changes include adding an initialRowHighlightHint prop to the relevant components, passing down the hint from DBTracePanel to DBTraceWaterfallChartContainer and DBRowSidePanel, and updating DBRowDataPanel to extract the necessary timestamp and span id information.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/app/src/components/DBTraceWaterfallChart.tsx | Added initialRowHighlightHint prop and associated useEffect for span highlighting in the chart. |
packages/app/src/components/DBTracePanel.tsx | Passed through initialRowHighlightHint to the chart container. |
packages/app/src/components/DBRowSidePanel.tsx | Computed initialRowHighlightHint based on normalized row data. |
packages/app/src/components/DBRowDataPanel.tsx | Updated timestamp and span ID extraction and display expressions. |
Comments suppressed due to low confidence (1)
packages/app/src/components/DBTraceWaterfallChart.tsx:300
- Ensure that the property names used in initialRowHighlightHint match those used in rows. If normalized row data uses keys like '__hdx_timestamp', '__hdx_span_id', and '__hdx_body', consider aligning these with the chart's property names (Timestamp, SpanId, Body) so that the comparison works as expected.
row.Timestamp === initialRowHighlightHint.timestamp && row.SpanId === initialRowHighlightHint.spanId && row.Body === initialRowHighlightHint.body
No description provided.