Add autoscaler plugin to Hyperflow docker image, add possibility to specify port and host when runnng as server #63
Conversation
…pecify port and host when running as server
|
All changes are fine except the replacement of the base image for the Hyperflow Dockerfile. This is a rather big change, can we add the autoscale plugin as a package? |
|
|
||
| async function k8sCommand(ins, outs, context, cb) { | ||
| /** Buffer Manager configuration. */ | ||
| const wfId = context.appConfig.wfId; |
There was a problem hiding this comment.
wfId is available as context.appId (a different name is used due to historical reasons :-)). So, no need to pass it via appConfig.
| async = require('async'), | ||
| eventServerFactory = require('../eventlog'); | ||
| eventServerFactory = require('../eventlog'), | ||
| removeBufferManager = require('../functions/kubernetes/k8sCommand').removeBufferManager; |
There was a problem hiding this comment.
engine2 is a core module, it would be best not to change it unless absolutely necessary. Creating dependency to a workflow function (which can easily be refactored out to a separate package) is not good.
|
|
||
| Engine.prototype.workflowFinished = function() { | ||
| console.log("Workflow ["+this.wfId+"] finished. Exec trace:", this.trace+"." ); | ||
| removeBufferManager(this.wfId); |
There was a problem hiding this comment.
This new part should be done outside engine2. The Engine can use eventServer to publish an event which can be received in another module. Something like eventServer.emit("trace.workflow.finished") should be okay. See various examples of usage.
| COPY . /hyperflow | ||
| RUN npm install -g /hyperflow | ||
|
|
||
| RUN mkdir -p /tmp/kubectl && cd /tmp/kubectl && apk add curl && \ |
| } | ||
| }); | ||
|
|
||
| if (wfConfig.containerSpec) { |
There was a problem hiding this comment.
I'm wondering where these containerSpec files should be published? Perhaps in workflow repositories, e.g. montage2-workflow?
|
|
||
| async function k8sCommand(ins, outs, context, cb) { | ||
| /** Buffer Manager configuration. */ | ||
| const wfId = context.appConfig.wfId; |
There was a problem hiding this comment.
const wfId = context.appId !!! Already available!
2 participants
No description provided.