Skip to content

Conversation

@Sam-61s
Copy link
Contributor

@Sam-61s Sam-61s commented Jan 30, 2026

  1. Updated gcd/lcm logic to correctly handle floating point precision issue
  2. Added test case that ensures it produces expected error message

closes #154

Copy link
Collaborator

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that works. Please undo the whitespace changes in the JSON test file. The only change should be the new tests.

@Sam-61s Sam-61s force-pushed the fix/decimal-multipleOf-precision branch from 845b5d9 to 92f6efa Compare February 2, 2026 04:33
Copy link
Collaborator

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdesrosiers jdesrosiers merged commit 671315b into hyperjump-io:main Feb 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect combined multipleOf value when using decimal constraints

2 participants