Skip to content

Conversation

@Sam-61s
Copy link
Contributor

@Sam-61s Sam-61s commented Jan 25, 2026

Summary

Fixes a runtime crash in the requireAllExcept keyword where remove() was called on a generator returned by Browser.keys().

Fix

Convert propertyNames to a Set
Replace invalid remove() call with Set.delete()

-requireAllExcept.forEach((propertyName) => propertyNames.remove(propertyName));
+requireAllExcept.forEach((propertyName) => required.delete(propertyName));

Result

Validation no longer crashes and correctly fails when required properties are missing.

Related Issue

Fixes #99

@Sam-61s Sam-61s force-pushed the fix/requireAllExcept-remove-crash branch from a3c88f2 to 39c1198 Compare January 25, 2026 10:35
@Sam-61s Sam-61s force-pushed the fix/requireAllExcept-remove-crash branch from 39c1198 to b61954d Compare January 25, 2026 10:39
Copy link
Collaborator

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdesrosiers jdesrosiers merged commit 8c8cb57 into hyperjump-io:main Jan 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requireAllExcept: Runtime Error - propertyNames.remove is not a function

2 participants