fix: bundle test-utils uses entry.path causing ENOENT on Windows; should use entry.parentPath #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
pushed a commit
that referenced
this pull request
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The bundler fixtures loader uses
entry.pathfromfs.readdirSync({ withFileTypes: true, recursive: true }).On Windows, Dirent.path can be undefined, so npm test fails with ENOENT
Fix: In test-utils.js , replace entry.path with entry.parentPath for path building and readFileSync. This matches existing usage in
v1/json-schema-test-suite.spec.tsand works cross‑platform.Linux/WSL note: Dirent.path is often defined there, so the bug is masked; parentPath avoids the platform-dependent behavior.