fix: contains behavior when minContains is 0 #98
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
containshandling whenminContainsis set to0.Per JSON Schema Validation 2020-12 6.4.5,
minContains: 0must always passvalidation while still enforcing
maxContains. This change removes anincorrect early return and preserves evaluated item annotations.
Spec reference:
https://json-schema.org/draft/2020-12/json-schema-validation.html#name-mincontains
All JSON Schema Test Suite tests pass.