This repository was archived by the owner on Apr 13, 2022. It is now read-only.
Conversation
kushti
suggested changes
Jan 15, 2021
Contributor
kushti
left a comment
kushti
left a comment
There was a problem hiding this comment.
Looks good in general, but I need to test it (also, consider writing tests for the code). Please do PR description (and correct title maybe , as PR is not just about eviction). Also, please do comments, left some notes on that.
|
|
||
| private def getIpGroup(addr : InetSocketAddress) : Int = { | ||
| val ip = addr.getAddress.getAddress | ||
| val group = ((ip(0) & 0xFF) << 8) | (ip(1) & 0xFF) |
Contributor
There was a problem hiding this comment.
Please comment non-trivial logic like this
| group | ||
| } | ||
|
|
||
| case class RandomPeerExcluding(excludedPeers: Seq[PeerInfo]) extends GetPeers[Option[PeerInfo]] { |
Contributor
There was a problem hiding this comment.
Please do a ScalaDoc describing implemented strategy details
knizhnik
added a commit
that referenced
this pull request
Jan 22, 2021
[refer #394] Try to choose candidates from different groups Signed-off-by: Konstantin Knizhnik <knizhnik@garret.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.