Skip to content

chore: configure hpa behavior #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: configure hpa behavior #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions helm/templates/hypertrace-collector/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,23 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
{{- if .Values.hpa.behavior.enabled }}
behavior:
scaleUp:
policies:
- type: {{ .Values.hpa.behavior.scaleUp.policy.type }}
value: {{ .Values.hpa.behavior.scaleUp.policy.value }}
periodSeconds: {{ .Values.hpa.behavior.scaleUp.policy.periodSeconds }}
selectPolicy: {{ .Values.hpa.behavior.scaleUp.selectPolicy }}
stabilizationWindowSeconds: {{ .Values.hpa.behavior.scaleUp.stabilizationWindowSeconds }}
scaleDown:
policies:
- type: {{ .Values.hpa.behavior.scaleDown.policy.type }}
value: {{ .Values.hpa.behavior.scaleDown.policy.value }}
periodSeconds: {{ .Values.hpa.behavior.scaleDown.policy.periodSeconds }}
selectPolicy: {{ .Values.hpa.behavior.scaleDown.selectPolicy }}
stabilizationWindowSeconds: {{ .Values.hpa.behavior.scaleDown.selectPolicy }}
{{- end }}
minReplicas: {{ int .Values.hpa.minReplicas }}
maxReplicas: {{ int .Values.hpa.maxReplicas }}
scaleTargetRef:
Expand Down
16 changes: 16 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,22 @@ hpa:
minReplicas: 2
maxReplicas: 5
targetCPUUtilizationPercentage: 80
behavior:
enabled: false
Copy link

@satish-mittal satish-mittal May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not enable here?

scaleUp:
policy:
type: Pods
value: 2
periodSeconds: 60
selectPolicy: Max
stabilizationWindowSeconds: 0
scaleDown:
policy:
type: Pods
value: 1
periodSeconds: 600
selectPolicy: Min
stabilizationWindowSeconds: 600

podmonitor:
enabled: false
Expand Down