Skip to content

Update descriptions used as aria-labels in FilterControls #7482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karenrasmussen wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Update descriptions used as aria-labels in FilterControls #7482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sidebar/components/search/FilterControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export default function FilterControls({
{hasSelection && (
<FilterToggle
label={`${selectedCount} selected`}
description={`Show ${selectedCount} selected annotations`}
description={`Show only the ${selectedCount} selected annotations. Press to clear this filter and show all annotations.`}
active={true}
setActive={() => store.clearSelection()}
testId="selection-toggle"
Expand All @@ -172,7 +172,7 @@ export default function FilterControls({
<FilterToggle
icon={ProfileIcon}
label={`By ${focusFilters.user.display}`}
description={`Show annotations by ${focusFilters.user.display}`}
description={`Show annotations by ${focusFilters.user.display}. Press to clear this filter.`}
active={focusActive.has('user')}
// When a selection exists, it replaces other filters.
disabled={hasSelection}
Expand All @@ -184,7 +184,7 @@ export default function FilterControls({
<FilterToggle
icon={FileGenericIcon}
label={`Pages ${focusFilters.page.display}`}
description={`Show annotations on pages ${focusFilters.page.display}`}
description={`Show annotations on pages ${focusFilters.page.display}. Press to clear this filter.`}
active={focusActive.has('page')}
disabled={hasSelection}
setActive={() => store.toggleFocusMode({ key: 'page' })}
Expand All @@ -195,7 +195,7 @@ export default function FilterControls({
<FilterToggle
icon={FileGenericIcon}
label="Selected chapter"
description="Show annotations on selected book chapter(s)"
description="Show annotations on selected book chapter(s). Press to clear this filter."
active={focusActive.has('cfi')}
disabled={hasSelection}
setActive={() => store.toggleFocusMode({ key: 'cfi' })}
Expand Down