fix(client): correctly handle coordinate SceneUI attachment#8
Open
AnrokX wants to merge 1 commit intohytopiagg:mainfrom
Open
fix(client): correctly handle coordinate SceneUI attachment#8AnrokX wants to merge 1 commit intohytopiagg:mainfrom
AnrokX wants to merge 1 commit intohytopiagg:mainfrom
Conversation
Author
|
Edge case: while SceneUI is pending template registration, merge logic drops Minimal fix: in pending merge, treat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SceneUIinstances for an initial position sync when they are created on the client.SceneUI.setPosition(...)is used, keeping attachment modes mutually exclusive.Notes
Testing