-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add spec coverage reporting to PRs #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new CI job that posts JMAP spec coverage as a PR comment: - Create .github/scripts/post-coverage.js for posting comments - Add Spec Coverage job that runs on PRs with submodule checkout - Capture coverage:spec --by-type output and post via github-script https://claude.ai/code/session_01BKenThf76JjbsGoqPWybft
- Add pull-requests: write permission to spec-coverage job - Use context.payload.pull_request.number for PR number - Use unique heredoc delimiter to avoid output conflicts https://claude.ai/code/session_01BKenThf76JjbsGoqPWybft
Package.json has "type": "module" so .js files are treated as ES modules. Rename to .cjs to allow require() from github-script action. https://claude.ai/code/session_01BKenThf76JjbsGoqPWybft
JMAP Spec Coverage |
- Add --markdown flag to spec-coverage.ts for GitHub-flavored tables - Update CI workflow to use --markdown instead of --by-type - Remove code block wrapper since markdown renders natively https://claude.ai/code/session_01BKenThf76JjbsGoqPWybft
JMAP Spec Coverage
Overall: 15/31 methods (48.4%)
|
Each object type now has its own table with methods in separate rows. Format: Method | Status columns for cleaner PR comments. https://claude.ai/code/session_01BKenThf76JjbsGoqPWybft
JMAP Spec Coverage
Overall: 15/31 methods (48.4%) Blob (0/4)
Core (0/1)
Email (6/8)
EmailSubmission (5/5)
Identity (0/3)
Mailbox (4/5)
SearchSnippet (0/1)
Thread (0/2)
VacationResponse (0/2)
|
effect-jmap-release bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
# [0.7.0](v0.6.0...v0.7.0) (2026-01-23) ### Features * Add spec coverage reporting to PRs ([#13](#13)) ([34ac9eb](34ac9eb))
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new CI job that posts JMAP spec coverage as a PR comment:
https://claude.ai/code/session_01BKenThf76JjbsGoqPWybft