feat: Add email destruction support via Email/set destroy #14
+189
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement permanent email deletion following the JMAP RFC 8621 specification: - Add `destroy` method to EmailService interface for permanent email removal - Add `destroyEmails` convenience operation in EmailOperations - Add unit tests for the new destroy method - Add functional tests for email deletion against real JMAP server The destroy operation permanently removes emails from the server, unlike the existing deleteEmails which moves emails to trash. https://claude.ai/code/session_01CGSojY6eQvSvpBWFMxtBcU
The spec tests already cover Email/set destroy functionality. Functional tests were unnecessary duplication. https://claude.ai/code/session_01CGSojY6eQvSvpBWFMxtBcU
JMAP Spec Coverage
Overall: 15/31 methods (48.4%) Blob (0/4)
Core (0/1)
Email (6/8)
EmailSubmission (5/5)
Identity (0/3)
Mailbox (4/5)
SearchSnippet (0/1)
Thread (0/2)
VacationResponse (0/2)
|
Add checklist for implementing JMAP methods: - Check capabilities.ts before starting - Search spec tests for existing coverage - Document testing structure (spec/unit/functional) - Note that create/update/destroy are /set parameters https://claude.ai/code/session_01CGSojY6eQvSvpBWFMxtBcU
JMAP Spec Coverage
Overall: 15/31 methods (48.4%) Blob (0/4)
Core (0/1)
Email (6/8)
EmailSubmission (5/5)
Identity (0/3)
Mailbox (4/5)
SearchSnippet (0/1)
Thread (0/2)
VacationResponse (0/2)
|
- Create docs/implementing-jmap-methods.md with full checklist - Update AGENTS.md to reference the new guide - Document testing structure and common pitfalls https://claude.ai/code/session_01CGSojY6eQvSvpBWFMxtBcU
JMAP Spec Coverage
Overall: 15/31 methods (48.4%) Blob (0/4)
Core (0/1)
Email (6/8)
EmailSubmission (5/5)
Identity (0/3)
Mailbox (4/5)
SearchSnippet (0/1)
Thread (0/2)
VacationResponse (0/2)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement permanent email deletion following the JMAP RFC 8621 specification:
destroymethod to EmailService interface for permanent email removaldestroyEmailsconvenience operation in EmailOperationsThe destroy operation permanently removes emails from the server, unlike
the existing deleteEmails which moves emails to trash.
https://claude.ai/code/session_01CGSojY6eQvSvpBWFMxtBcU