Extractor: Handle object props as namespace#205
Merged
adrai merged 1 commit intoi18next:mainfrom Mar 4, 2026
Merged
Conversation
Member
|
v1.47.12 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to handle object properties in #204 😓
This will handle those cases as well, which I found quite a few uses of in our own code at least,
where you define a const object of namespaces.
Hopefully this isn't too niche, but I do think that the more common patterns the extractor can cover
the better the cli is :)
Checklist
npm run test