Resolve and safe constants cross-files#207
Merged
adrai merged 1 commit intoi18next:mainfrom Mar 4, 2026
Merged
Conversation
Member
|
maybe not that easy, but can you try to create a test for that? |
When importing variables from other files, we need to keep the declarations so the declarations are saved for future reference when processing other files.
bbceee3 to
fd4b435
Compare
Contributor
Author
Sure! |
Member
|
thx... included in v1.48.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another one from me here 😅
When importing variables from other files, we need to keep the
declarations so the declarations are saved for future reference when
processing other files.
This fixes cases where declarations of variables passed to
useTranslationare defined in otherfiles. The quirk here is that you need to ensure the files containing the declarations are parsed
before any other usages of those declarations.
Checklist
npm run test