Fixed: add file extensions to all imports (for d.ts files) (#137)#211
Merged
adrai merged 1 commit intoi18next:mainfrom Mar 5, 2026
Merged
Fixed: add file extensions to all imports (for d.ts files) (#137)#211adrai merged 1 commit intoi18next:mainfrom
adrai merged 1 commit intoi18next:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
feels "strange" to have ts files imported as .js but if this is the way it should work, i'm ok with that... |
Contributor
Author
|
It is strange indeed, there were already long discussions about that :) |
Member
|
Yes, maybe before I merge this, please try what you can and let me know... |
Contributor
Author
|
Rollup issues errors when using ts extensions, and I did not find a way to fix this by using some options in tsconfig.json or rollup.config.js. |
Member
|
ok, then I merge |
Member
|
included in v1.49.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
.jsfile extensions inimportstatements of all source files, there is no other way to convince TSC to write file extensions into the generatedd.tsfileseslint-plugin-importto accept the file extensions (added TypeScript support, needs two new dev dependencies)extractfunction) so TypeScript does not auto-generatePromise<import("../../types").Translationresult[]>without extensionThis does not change the generated code in
distat all, Rollup has always added file extensions in all imports for both the esm and cjs builds.Checklist
npm run testChecklist (for documentation change)