Minor fix for MedicationPrescription search by patient#6
Open
ewall wants to merge 1 commit intoi3l:FHIR-DSTUfrom
Open
Minor fix for MedicationPrescription search by patient#6ewall wants to merge 1 commit intoi3l:FHIR-DSTUfrom
ewall wants to merge 1 commit intoi3l:FHIR-DSTUfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a really minor fix for an annoying bug in the HealthPort server as its currently deployed. (No need for extra credit, just wanting to make the code better for the next class!)
The FHIR DSTU spec says that you should be able to search MedicationPrescription resources with the keyword "patient", but the current HealthPort code uses the "subject" paramter for this instead.
"Incorrect" URL that works on the current version:
http://localhost:8080/HealthPort/fhir/MedicationPrescription?patient:Patient=Patient/3.568001602-01
Corrected URL that works after this update:
http://localhost:8080/HealthPort/fhir/MedicationPrescription?patient:Patient=Patient/3.568001602-01
An alternate solution would be to duplicate the
getMedicationPrescriptionsByPatient()method so one accepts 'subject' and the other accepts 'patient' (for backwards compatibility), but for future use I believe it's better to follow the spec to avoid confusion.