Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Lighthouse v13 Migration + Network Waterfall
Problem
Lighthouse v13 (#16595) removed 24 performance audits that were replaced by insight audits. Our reports were breaking — missing data in metric-relevant-audit mappings, and custom audits failing due to renamed artifact keys.
What changed
v13 Compatibility Fixes
requiredArtifacts: ['traces']requiredArtifacts: ['Trace']artifacts.traces[Audit.DEFAULT_PASS]artifacts.Traceartifacts.devtoolsLogs[Audit.DEFAULT_PASS]artifacts.DevtoolsLogimport i18n from '...'import * as i18n from '...'render-blocking-resources,server-response-time, etc.render-blocking-insight,server-response-time-insight, etc.uses-optimized-images,uses-text-compressionFiles affected: all 11 custom audits,
metrics-to-audits.js,csv.jsNetwork Waterfall Visualization (new)
Added an inline SVG waterfall chart that renders inside each Lighthouse report step:
New files:
settings/audits/network-waterfall.js— custom audit embedding the SVG viavalueType: 'thumbnail'reporting/waterfall.js—buildWaterfallSVG()generatorModified:
settings/lighthouse.js— registerednetwork-waterfallaudit inserver-sidecategoryreporting/createReport.js— injects CSS overrides so the SVG renders at full widthNetwork Requests Table Cleanup
Network Request Timegranularity: 1+displayUnit: 'kb'Screenshots
Testing
Verified:
Breaking Changes
None for consumers — this is a drop-in upgrade. The framework now requires Lighthouse ≥ 13.0.0.