Fix Edit User: Handle the case where the user still has no assigned groups #34
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the UserController to ensure that the assigned_groups input defaults to an empty array if not provided. This change prevents potential errors when changing a user's role when said user has still no assigned groups.
Collaborator
Author
|
QA 👍 Confirmed no errors occurred in the test cluster 2025-06-26_10-44-40.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We end up with an error when we try to change the role of a user who still has not been assigned a group.
2025-06-26_10-28-43.mp4
CR Notes
This was reported by Amber when she tried to change the role for new users on the live site.
QA Notes
We should no longer get an error when we try to update another user's role.