chore(env): update email configuration in .env files #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the email settings in .env.base and .env.template to replace MAIL_SCHEME with MAIL_ENCRYPTION, and added MAIL_FROM_ADDRESS and MAIL_FROM_NAME. These changes are necessary to use SendGrid as the mailer.
Lets use a secret for the mailer credentials.
Collaborator
Author
|
QA 👍 I confirmed the new Helm Chart settings work and we can send emails through SendGrid |
mlahargou
reviewed
Jul 1, 2025
| MAIL_PASSWORD=null | ||
| MAIL_SCHEME=null | ||
| MAIL_ENCRYPTION=null | ||
| MAIL_FROM_ADDRESS=noreply@restarters.test |
Member
There was a problem hiding this comment.
Just curious, is this a real address?
Collaborator
Author
There was a problem hiding this comment.
Nah we're good. The .test domains are reserved https://en.wikipedia.org/wiki/.test
mlahargou
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the Mail env vars to work with SendGrid. We needed the
MAIL_ENCRYPTION,MAIL_FROM_ADDRESS, andMAIL_FROM_NAMEto get the app working with SendGrid.This also updates the Helm Chart to now include the new Mail env vars in the values.yaml file and extracts the Mailer credentials to a Secret.
QA Notes
I already tested the env vars change in the test cluster but I have not tested the changes to the Helm Chart. As such, we will need to target this branch in the test ArgoCD app to confirm the changes worked.