Feature: Add migration tool for external auth users #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user created via local auth has the same email address as an iFixit user, then they will be unable to login to the site with their iFixit account. We can't really delete the users from the DB if they have already created groups and events. As such, this migration tool will allow us to manually sync/migrate the users with their iFixit counterparts.
ardelato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user created via local auth has the same email address as an iFixit user, then they will be unable to login to the site with their iFixit account. We throw a SQL error because we attempt to create a new user with the external auth, but two users can't share the same email address.
We can't really delete the users from the DB if they have already created groups and events. We also cannot automatically sync the local user with the iFixit account, if they share the same email, for security reasons - this approach would allow for account take over if someone uses an email address on iFixit that is the same on the Restarters app.
CR Notes
The solution is to create a Artisan command that we would manually run to migrate/sync a local auth user with their desired iFixit user.
qa_req 0 I already confirmed this works locally