Fix: Decouple NGINX health checks from PHP-FPM #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, nginx health probes were hitting /healthz which proxied to PHP-FPM/Laravel, creating a dependency chain where nginx would be marked unhealthy and restart due to database or PHP-FPM issues. This caused: - False nginx failures when the problem was elsewhere - Startup race conditions (nginx checked at 45s, PHP-FPM ready at 60s) - Cascading failures and unnecessary restarts Changes: - Add dedicated /nginx-health endpoint that returns 200 directly from nginx - Update nginx liveness/readiness probes to use /nginx-health - Reduce initialDelaySeconds (10s/5s) since nginx starts faster - Reduce timeouts to 5s for faster failure detection Laravel /healthz endpoint remains available for application-level health monitoring and external tools. Fixes nginx container restart issues in EKS.
Collaborator
Author
|
QA 👍 ArgoCD is still reporting healthy containers and pod. 
NGINX is still working as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, nginx health probes were hitting /healthz which proxied to PHP-FPM/Laravel, creating a dependency chain where nginx would be marked unhealthy and restart due to database or PHP-FPM issues.
This caused:
Changes:
Laravel /healthz endpoint remains available for application-level health monitoring and external tools.
Fixes nginx container restart issues in EKS.
QA Notes
Its uncertain if this will actually resolve the constant container restart issue, but we should at least validate the deployment still works in the test cluster first.
Reference: https://ifixit.slack.com/archives/C09FMSNS1/p1767808200093109