Skip to content

Conversation

@jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Fix a few compiler warnings: change throw to noexcept, add override and default

ENDRELEASENOTES

The warnings with Clang 21:

In file included from /k4MarlinWrapper/k4MarlinWrapper/src/components/MarlinProcessorWrapper.cpp:20:
In file included from /k4MarlinWrapper/k4MarlinWrapper/k4MarlinWrapper/MarlinProcessorWrapper.h:35:
/Marlin/source/include/marlin/Exceptions.h:21:31: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
   21 |     virtual ~ParseException() throw() { /*no_op*/; }
      |                               ^~~~~~~
/Marlin/source/include/marlin/Exceptions.h:21:31: note: use 'noexcept' instead
   21 |     virtual ~ParseException() throw() { /*no_op*/; }
      |                               ^~~~~~~
      |                               noexcept
/Marlin/source/include/marlin/Exceptions.h:43:35: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
   43 |     virtual ~SkipEventException() throw() { /*no_op*/; }
      |                                   ^~~~~~~
/Marlin/source/include/marlin/Exceptions.h:43:35: note: use 'noexcept' instead
   43 |     virtual ~SkipEventException() throw() { /*no_op*/; }
      |                                   ^~~~~~~
      |                                   noexcept
/Marlin/source/include/marlin/Exceptions.h:61:40: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
   61 |     virtual ~StopProcessingException() throw() { /*no_op*/; }
      |                                        ^~~~~~~
/Marlin/source/include/marlin/Exceptions.h:61:40: note: use 'noexcept' instead
   61 |     virtual ~StopProcessingException() throw() { /*no_op*/; }
      |                                        ^~~~~~~
      |                                        noexcept
/Marlin/source/include/marlin/Exceptions.h:79:41: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
   79 |     virtual ~RewindDataFilesException() throw() { /*no_op*/; }
      |                                         ^~~~~~~
/Marlin/source/include/marlin/Exceptions.h:79:41: note: use 'noexcept' instead
   79 |     virtual ~RewindDataFilesException() throw() { /*no_op*/; }
      |                                         ^~~~~~~
      |                                         noexcept

override and default don't give any warnings, although for override there is one if enabled.

@tmadlener
Copy link
Contributor

Closing and opening again to trigger workflows that have been disabled.

@tmadlener tmadlener closed this Jan 22, 2026
@tmadlener tmadlener reopened this Jan 22, 2026
@tmadlener tmadlener enabled auto-merge (squash) January 22, 2026 08:31
@tmadlener tmadlener disabled auto-merge January 22, 2026 09:17
@tmadlener tmadlener merged commit f719ee7 into iLCSoft:master Jan 22, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants