Open
Conversation
Collaborator
Author
|
@YouriRan can we create a branch called CycleSim so that we can develop there? |
Collaborator
|
Hi Hassan, I think it would be best to work on your own fork. If you feel that this code is ready for review, let me know, then I will review and merge if it's ready. |
Collaborator
Author
|
We will do that thanks @YouriRan |
Collaborator
Author
|
@YouriRan could you review the code? We have added different numerical discretization scheme and time steps on top of previous commits. |
Collaborator
|
Sure! I will probably have time on Friday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented by @hassan-azizi