Use vite beta version based on rolldown instead of esbuild#1190
Draft
saskliutas wants to merge 1 commit intomasterfrom
Draft
Use vite beta version based on rolldown instead of esbuild#1190saskliutas wants to merge 1 commit intomasterfrom
saskliutas wants to merge 1 commit intomasterfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Unified selection benchmark
| Benchmark suite | Current: 75378d6 | Previous: 36e1832 | Deviation | Status |
|---|---|---|---|---|
hilite 50k elements |
1304.28 ms |
1338.26 ms |
-2.54% |
〰️ |
hilite 50k elements (P95 of main thread blocks) |
50 ms |
50 ms |
0% |
🟰 |
hilite 50k group elements |
235.75 ms |
243.42 ms |
-3.15% |
〰️ |
hilite 50k group elements (P95 of main thread blocks) |
32 ms |
31 ms |
3.23% |
〰️ |
hilite 1k subjects |
46050.55 ms |
46239.76 ms |
-0.41% |
〰️ |
hilite 1k subjects (P95 of main thread blocks) |
34 ms |
32 ms |
6.25% |
〰️ |
hilite 50k subcategories |
280.79 ms |
304.54 ms |
-7.80% |
〰️ |
hilite 50k subcategories (P95 of main thread blocks) |
33 ms |
34 ms |
-2.94% |
〰️ |
hilite 50k functional 3D elements |
28726.13 ms |
28421.38 ms |
1.07% |
〰️ |
hilite 50k functional 3D elements (P95 of main thread blocks) |
41 ms |
43 ms |
-4.65% |
〰️ |
hilite 50k functional 2D elements |
6676.74 ms |
6737.41 ms |
-0.90% |
〰️ |
hilite 50k functional 2D elements (P95 of main thread blocks) |
45 ms |
45 ms |
0% |
🟰 |
compute selection for 50k elements |
344 ms |
343.08 ms |
0.27% |
〰️ |
compute selection for 50k elements (P95 of main thread blocks) |
38 ms |
38 ms |
0% |
🟰 |
compute parent selection for 50k elements |
336.02 ms |
336.74 ms |
-0.21% |
〰️ |
compute parent selection for 50k elements (P95 of main thread blocks) |
31 ms |
31 ms |
0% |
🟰 |
compute top ancestor selection for 50k elements |
547.09 ms |
569.74 ms |
-3.98% |
〰️ |
compute top ancestor selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute category selection for 50k elements |
96.65 ms |
95.07 ms |
1.66% |
〰️ |
compute category selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute model selection for 50k elements |
72.71 ms |
71.21 ms |
2.11% |
〰️ |
compute model selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 3D elements |
402.73 ms |
397.64 ms |
1.28% |
〰️ |
compute functional selection for 50k 3D elements (P95 of main thread blocks) |
31 ms |
33 ms |
-6.06% |
〰️ |
compute parent functional selection for 50k 3D elements |
438.46 ms |
433.5 ms |
1.14% |
〰️ |
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) |
32 ms |
31 ms |
3.23% |
〰️ |
compute top ancestor functional selection for 50k 3D elements |
1148.61 ms |
1195.18 ms |
-3.90% |
〰️ |
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 2D elements |
3082.84 ms |
3149.44 ms |
-2.11% |
〰️ |
compute functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute parent functional selection for 50k 2D elements |
3044.57 ms |
3189.91 ms |
-4.56% |
〰️ |
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute top ancestor functional selection for 50k 2D elements |
3164.75 ms |
3223.58 ms |
-1.82% |
〰️ |
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Hierarchies benchmark
| Benchmark suite | Current: 75378d6 | Previous: 36e1832 | Deviation | Status |
|---|---|---|---|---|
flat 50k elements list |
4604.35 ms |
4695.96 ms |
-1.95% |
〰️ |
flat 50k elements list (P95 of main thread blocks) |
71 ms |
70 ms |
1.43% |
〰️ |
filtering filters with 50000 paths |
8854.93 ms |
9023.05 ms |
-1.86% |
〰️ |
filtering filters with 50000 paths (P95 of main thread blocks) |
121 ms |
127 ms |
-4.72% |
〰️ |
grouping by label |
10640.16 ms |
10582.92 ms |
0.54% |
〰️ |
grouping by label (P95 of main thread blocks) |
61 ms |
54 ms |
12.96% |
〰️ |
grouping by class |
10099.31 ms |
10335.31 ms |
-2.28% |
〰️ |
grouping by class (P95 of main thread blocks) |
38 ms |
44 ms |
-13.64% |
〰️ |
grouping by property |
10799.53 ms |
11161.52 ms |
-3.24% |
〰️ |
grouping by property (P95 of main thread blocks) |
48 ms |
48 ms |
0% |
🟰 |
grouping by base class (10 classes) |
7507.38 ms |
7999.35 ms |
-6.15% |
〰️ |
grouping by base class (10 classes) (P95 of main thread blocks) |
55 ms |
64 ms |
-14.06% |
〰️ |
grouping by multiple attributes |
26555.64 ms |
27889.17 ms |
-4.78% |
〰️ |
grouping by multiple attributes (P95 of main thread blocks) |
48 ms |
60 ms |
-20% |
〰️ |
hide if no children required to finalize root, w/o children |
42431.76 ms |
44983.67 ms |
-5.67% |
〰️ |
hide if no children required to finalize root, w/o children (P95 of main thread blocks) |
38 ms |
38 ms |
0% |
🟰 |
hide if no children required to finalize root, w/ children |
163.54 ms |
169.22 ms |
-3.36% |
〰️ |
hide if no children required to finalize root, w/ children (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree initial (Baytown) |
42.35 ms |
44.6 ms |
-5.04% |
〰️ |
models tree initial (Baytown) (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree full (Baytown) |
6723.25 ms |
6835.93 ms |
-1.65% |
〰️ |
models tree full (Baytown) (P95 of main thread blocks) |
104 ms |
90 ms |
15.56% |
〰️ |
models tree creates initial filtered view for 50k target items |
2199.87 ms |
2188.34 ms |
0.53% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
359 ms |
62 ms |
479.03% |
🚨 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to the latest vite version based on rolldown. This should provide performance increase in bundled and dev server workflows.