Skip to content

[Tree widget]: Test out caching visibility status based on ids.#1601

Draft
JonasDov wants to merge 2 commits intotree-widget/nextfrom
JonasD/caching-visibility-on-ids
Draft

[Tree widget]: Test out caching visibility status based on ids.#1601
JonasDov wants to merge 2 commits intotree-widget/nextfrom
JonasD/caching-visibility-on-ids

Conversation

@JonasDov
Copy link
Contributor

WIP

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget Next benchmark

Benchmark suite Current: 9304f7d Previous: aa9844b Deviation Status
categories tree creates initial filtered view for 50k items 1593.44 ms 1561.96 ms 2.02% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 154 ms 165 ms -6.67% 〰️
categories tree changing definition container visibility changes visibility for 50k subCategories 4428.42 ms 4629.84 ms -4.35% 〰️
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) 66 ms 62 ms 6.45% 〰️
categories tree changing definition container visibility changes visibility for 50k categories 156301.77 ms 142199.28 ms 9.92% 〰️
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 2398 ms 2050 ms 16.98% 🚨
classifications tree loads initial view for iModel with 50k classifications 42.93 ms 45.66 ms -5.98% 〰️
classifications tree loads initial view for iModel with 50k classifications (P95 of main thread blocks) 21 ms 23 ms -8.70% 〰️
classifications tree loads first branch for iModel with 50k classifications 1225.5 ms 1103.19 ms 11.09% 🚨
classifications tree loads first branch for iModel with 50k classifications (P95 of main thread blocks) 153 ms 126 ms 21.43% 〰️
models tree creates initial filtered view for 50k target items 1008.46 ms 1014.05 ms -0.55% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 107 ms 137 ms -21.90% 〰️
models tree validates categories visibility for imodel with 50k categories 4123.83 ms 11875.22 ms -65.27%
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) 386 ms 628 ms -38.54%
models tree changing model visibility changes visibility for 50k elements 3176.83 ms 2807.48 ms 13.16% 🚨
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 22 ms 0 ms 2200% 〰️
models tree changing category visibility changes visibility for 50k elements 3207.76 ms 2937 ms 9.22% 〰️
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing per-model-category override changes visibility for 50k elements 3268.03 ms 3089.11 ms 5.79% 〰️
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing element visibility changes only parent nodes visibility with 50k elements 4082.33 ms 4449.85 ms -8.26% 〰️
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) 394 ms 432 ms -8.80% 〰️

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant