The most recent support of { block: 'end' }

[pmyagkov]

This is an actual rebase of #39 onto the most recent master.

[jeremenichelli]

Thanks a lot for the PR @pmyagkov. Now, there are some things that I really like from this PR, like the behavior and arguments checking, and some others I don't like changes involving personal code style preferences and lots of others misc topics like test site.

Are you or @DanielHeath available to discuss and update this PR after a review?

Thanks in advance to both for your work.

[pmyagkov]

@jeremenichelli code style is absolutely OK. Just write down your comments, I'll fix those. But I found no tests at all, so this testing approach is better than nothing.

Answering your question, yea, I'll fix your comments. Really want to get this merged.

[DanielHeath]

My original changeset turned out to be not quite right - on chrome desktop it was possible to get the scrollbar stuck at the top of the page (I suspect this happens if a target element is removed from the DOM while scrolling was in progress).

While this bug could be fixed, I'd also suggest adding a setTimeout that forces step to stop recursing. Without that, the current code will (for instance) break scrolling if your system clock changes by an hour (as happens automatically at daylight saving time / when NTP fixes your clock).

[pmyagkov]

@DanielHeath do you want to fix this by your own?

[DanielHeath]

I'm on paternity leave. Unlikely to get to it in the next 6 months; will post here if that changes.

…

On Nov 2, 2017, at 7:49 PM, Pavel Myagkov ***@***.***> wrote: @DanielHeath <https://github.com/danielheath> do you want to fix this by your own? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5Rqb36zZ9kqQUgcnM_93DNcbMhIqBks5syYH_gaJpZM4QM3wx>.

[pmyagkov]

@jeremenichelli @iamdustan so guys would you leave some review comments to fix here?

[jeremenichelli]

@pmyagkov we will indeed, right now we are busy and the PR is big, so it might takes us some time.

[soluml]

Any update on this?

[jeremenichelli]

@soluml I'm gonna have time soon to review this PR. I think that we'll need a strategy to tackle this specific part of the spec, so I don't expect this getting included soon because of the size of the PR itself and other reasons. Sorry.

[magic-akari]

https://drafts.csswg.org/cssom-view/#dictdef-scrollintoviewoptions
https://drafts.csswg.org/cssom-view/#enumdef-scrolllogicalposition

It is better to add the options of "center" and "nearest".

[malliapi]

@jeremenichelli - any news on updating this PR?

[malliapi]

@DanielHeath - same as above

[malliapi]

i was wondering if you guys had the time since you shown interest in the past as it looks like an awesome feature !

[DanielHeath]

@malliapi feel free to fix it up! I no longer need this.