Conversation
- Replace Card component with new header/footer based architecture - Add CardTitle, CardTitleWithIcon, CardSubtitle, and CardFooter components - Update MetricCard and ChartCard to use new Card API - Add ceramic color tokens and design system variables to CSS - Remove grid_cols parameter and legacy styling approach
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| def Card( | ||
| children: Any, | ||
| children: Children, | ||
| header: Children | None = None, | ||
| footer: Children | None = None, | ||
| className: str = "", | ||
| title: str | None = None, | ||
| grid_cols: Literal[1, 2, 3, 4, 6, 12, "full"] = 1, | ||
| **kwargs: Any, | ||
| ) -> html.Div: | ||
| """ | ||
| Reusable card component with consistent dashkit styling and grid support. | ||
| header_className: str | None = None, | ||
| body_className: str | None = None, | ||
| ) -> Component: |
There was a problem hiding this comment.
[P1] Restore passthrough of arbitrary props to Card
The revised Card API dropped the **kwargs parameter and never forwards arbitrary props to html.Section. Existing usage patterns—including MetricCard/ChartCard in this module—still forward **kwargs so any call that supplied standard Dash attributes such as id, style, or event handlers will now fail with TypeError: Card() got an unexpected keyword argument. This is a breaking regression that prevents cards from being uniquely identified or customized.
Useful? React with 👍 / 👎.
- Add **kwargs parameter back to Card function signature - Forward **kwargs to html.Section to allow standard Dash props - Fixes breaking regression preventing id, style, and event handlers
1 participant
Summary
Changes
Test plan