2019 Aug week4 #111
Open
2019 Aug week4 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iammapping
requested changes
Aug 27, 2019
Owner
iammapping
left a comment
iammapping
left a comment
There was a problem hiding this comment.
貌似 object 类的返回值，每次都会触发一个浅对比，会成为一个性能杀手，而且对于一些深层次的依赖也会遗漏。使用 defineProperty 委托的方式是对的，但不应该只委托 function 的类型，把其他的也加进来用于标记依赖。有兴趣可以看下 vue 的 computed 原理以及 immer.js 的实现方式。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.