feat: #99 Improve tournament competitor edit dialog

[ianpaschal]

Summary by CodeRabbit

• New Features

  • Added dynamic player slot management in team forms, allowing users to add player slots and ensuring only players with valid user IDs are submitted.
  • The team competitor edit form is now scrollable for improved usability with large teams.

• Bug Fixes

  • Improved validation and error messages for the number of active players in a team.

• Style

  • Updated styles so that the "Add Player Slot" button spans the full width of the player section.

• Refactor

  • Simplified and optimized form validation and default value logic.
  • Streamlined visibility conditions for competitor action menu items.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
combat-command	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 30, 2025 8:04pm

[coderabbitai]

Walkthrough

This update refines player slot management and validation in tournament competitor forms. It introduces dynamic player slot addition, filters out players without user IDs during submission, and improves scrollability in dialogs. Visibility conditions for competitor actions are simplified, and style and schema logic are streamlined for better maintainability.

Changes

Files/Groups	Change Summary
src/components/TournamentCompetitorEditDialog/TournamentCompetitorEditDialog.tsx	Filters out players without userId on submit; wraps form in a scrollable area.
src/components/TournamentCompetitorForm/TournamentCompetitorForm.module.scss	Adds grid-span style for the add-player button within the team players section.
src/components/TournamentCompetitorForm/TournamentCompetitorForm.schema.ts	Simplifies validation logic and refactors default value generation for the competitor form.
src/components/TournamentCompetitorForm/TournamentCompetitorForm.tsx	Implements dynamic player slot addition, null-safe props, disables input based on state, and filters out empty user IDs on submit.
src/components/TournamentRoster/components/CompetitorActions/CompetitorActions.tsx	Removes redundant user checks from action visibility conditions for leave, edit, and delete actions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TournamentCompetitorForm
    participant TournamentCompetitorEditDialog
    participant API

    User->>TournamentCompetitorForm: Clicks "Add Player Slot"
    TournamentCompetitorForm->>TournamentCompetitorForm: Appends new inactive player slot

    User->>TournamentCompetitorForm: Fills form and submits
    TournamentCompetitorForm->>TournamentCompetitorForm: Filters out players without userId
    TournamentCompetitorForm->>TournamentCompetitorEditDialog: Passes filtered data
    TournamentCompetitorEditDialog->>API: Sends update request with valid players only

Loading

Poem

In the warren of code, new slots appear,
Add a player, hop with cheer!
Scroll the form, let none be missed,
Only valid bunnies make the list.
Actions clear, the clutter gone—
The tournament’s flow hops bravely on!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-30T20_07_08_845Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/TournamentCompetitorEditDialog/TournamentCompetitorEditDialog.tsx (1)

30-34: Consider removing duplicate player filtering logic.

The filtering logic here duplicates what's already implemented in TournamentCompetitorForm.handleSubmit (line 113 in the form component). Both locations filter out players without userId.

While defensive programming can be beneficial, this duplication may lead to maintenance overhead. Consider whether the filtering is necessary at both levels.

If you want to keep the filtering for defensive purposes, consider adding a comment explaining why it's intentionally duplicated:

  const handleSubmit = (formData: TournamentCompetitorSubmitData): void => {
    if (!data) {
      return;
    }

    const { players, ...restData } = formData;
+   // Defensive filtering - form already filters, but ensuring no empty players reach the API
    updateTournamentCompetitor({
      id: data?.tournamentCompetitor._id,
      ...restData,
      players: players.filter((player) => player.userId),
    });
  };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89594e9 and 99c404f.

📒 Files selected for processing (5)

• src/components/TournamentCompetitorEditDialog/TournamentCompetitorEditDialog.tsx (2 hunks)
• src/components/TournamentCompetitorForm/TournamentCompetitorForm.module.scss (1 hunks)
• src/components/TournamentCompetitorForm/TournamentCompetitorForm.schema.ts (2 hunks)
• src/components/TournamentCompetitorForm/TournamentCompetitorForm.tsx (6 hunks)
• src/components/TournamentRoster/components/CompetitorActions/CompetitorActions.tsx (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/components/TournamentCompetitorEditDialog/TournamentCompetitorEditDialog.tsx (1)

src/components/TournamentCompetitorForm/TournamentCompetitorForm.tsx (1)

• TournamentCompetitorForm (49-192)

🔇 Additional comments (16)

src/components/TournamentCompetitorForm/TournamentCompetitorForm.module.scss (1)

15-17: LGTM! Clean CSS implementation for the full-width button.

The grid-column spanning rule correctly positions the "Add Player Slot" button to span both the Active and User columns in the players grid.

src/components/TournamentCompetitorEditDialog/TournamentCompetitorEditDialog.tsx (2)

7-7: Good UX improvement with ScrollArea.

Adding ScrollArea enables better handling of long player lists in the dialog.

---

41-49: ScrollArea implementation enhances form usability.

Wrapping the form in ScrollArea improves the user experience when dealing with tournaments that have many player slots.

src/components/TournamentRoster/components/CompetitorActions/CompetitorActions.tsx (3)

79-79: Good refactoring to remove redundant user checks.

The explicit user && check was redundant since isPlayer already verifies user existence. The change also improves the status check by using an array for better readability.

---

84-84: Correctly simplified visibility condition.

Removing the redundant user && check is appropriate since both isOrganizer and isPlayer already verify user existence.

---

89-89: Redundant user check properly removed.

The user && check was unnecessary since isOrganizer already includes user validation.

src/components/TournamentCompetitorForm/TournamentCompetitorForm.tsx (8)

1-1: MouseEvent import added for proper event handling.

Good addition for the new handleAddPlayer event handler.

---

11-11: Appropriate imports for the new Add Player Slot functionality.

Plus icon and Button component are correctly imported for the new dynamic player slot feature.

Also applies to: 19-19

---

76-76: Correctly added append method for dynamic player management.

The append method from useFieldArray is properly destructured to support adding new player slots.

---

102-108: Well-implemented handleAddPlayer function.

The logic correctly:

• Prevents default form submission behavior
• Appends new player slots with appropriate default values
• Sets active status based on current active player count vs competitor size
• Initializes with empty userId for user selection

---

110-116: Good practice filtering out incomplete players.

Filtering players without userId before submission prevents submitting incomplete data and aligns with the form's validation logic.

---

125-125: Smart calculation for managing empty slots.

The emptyPlayerSlots calculation effectively tracks unfilled player slots, enabling proper button state management.

---

146-146: Excellent defensive programming with optional chaining.

The optional chaining (players[i]?.active ?? false and players[i]?.userId) prevents potential runtime errors when accessing player data.

Also applies to: 152-152

---

160-168: Well-designed Add Player Slot button implementation.

The button implementation demonstrates good UX practices:

• Proper styling class application
• Smart disable logic (prevents adding when loading or empty slots exist)
• Clear visual design with Plus icon and descriptive text
• Proper event handling

src/components/TournamentCompetitorForm/TournamentCompetitorForm.schema.ts (2)

20-33: Excellent refactoring of validation logic.

The simplified validation conditions are more readable and maintainable:

• Combined separate if statements into clearer conditional blocks
• Improved error message consistency and clarity
• Maintained the same validation logic while reducing code complexity

---

50-56: Great refactoring to a concise and readable function.

The new implementation is much cleaner:

• Eliminates complex conditional logic and loops
• Uses modern JavaScript features (optional chaining, array methods)
• Maintains the same functionality while being more maintainable
• Returns only existing competitor players instead of pre-filling empty slots

This aligns well with the dynamic slot addition feature in the form component.