Skip to content

#306 Allow TOs to reveal and hide lists#312

Merged
ianpaschal merged 2 commits intomainfrom
306-allow-tos-to-reveal-and-hide-lists
Mar 2, 2026
Merged

#306 Allow TOs to reveal and hide lists#312
ianpaschal merged 2 commits intomainfrom
306-allow-tos-to-reveal-and-hide-lists

Conversation

@ianpaschal
Copy link
Owner

@ianpaschal ianpaschal commented Mar 2, 2026

Resolves: #306


@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
combat-command Ready Ready Preview, Comment Mar 2, 2026 4:13pm

@ianpaschal ianpaschal marked this pull request as ready for review March 2, 2026 16:00
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This change introduces a new toggle action for revealing or hiding tournament lists. It adds a new ToggleListsRevealed action key to the tournament action system, creates a corresponding server mutation that validates organizer permissions and toggles a listsRevealed boolean on tournament documents, and wires up the necessary client-side hooks and components to expose this functionality. The implementation follows the existing pattern of similar toggle actions like ToggleAlignmentsRevealed and ToggleFactionsRevealed. Additionally, a toast message in an existing toggle action is updated with fixed user-facing text.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and lacks substantive detail. It only includes a minimal reference to an issue without context, rationale, or implementation details. Expand the description to include: the feature purpose, implementation approach, changes made across files, testing performed, and any breaking changes or considerations.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '#306 Allow TOs to reveal and hide lists' accurately summarizes the main change: adding functionality for Tournament Organizers to control list visibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 306-allow-tos-to-reveal-and-hide-lists

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/TournamentProvider/actions/useToggleListsRevealedAction.ts`:
- Line 17: The label for the toggle action is derived from the wrong state;
change the label computation in useToggleListsRevealedAction (the object with
property label) to use listsRevealed instead of subject.alignmentsRevealed so
the button reflects the actual toggle state (i.e., label: listsRevealed ? 'Hide
Lists' : 'Reveal Lists'), and ensure any surrounding logic that sets or reads
listsRevealed remains consistent with the toggle handler.

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6dccbe and 298d0f5.

⛔ Files ignored due to path filters (1)
  • convex/_generated/api.d.ts is excluded by !**/_generated/**
📒 Files selected for processing (7)
  • convex/_model/tournaments/_helpers/getAvailableActions.ts
  • convex/_model/tournaments/index.ts
  • convex/_model/tournaments/mutations/toggleTournamentListsRevealed.ts
  • convex/tournaments.ts
  • src/components/TournamentProvider/actions/useToggleAlignmentsRevealedAction.ts
  • src/components/TournamentProvider/actions/useToggleListsRevealedAction.ts
  • src/services/tournaments.ts

…edAction.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@ianpaschal ianpaschal merged commit e4aabf7 into main Mar 2, 2026
3 checks passed
@ianpaschal ianpaschal deleted the 306-allow-tos-to-reveal-and-hide-lists branch March 2, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant