#306 Allow TOs to reveal and hide lists#312
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis change introduces a new toggle action for revealing or hiding tournament lists. It adds a new 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/TournamentProvider/actions/useToggleListsRevealedAction.ts`:
- Line 17: The label for the toggle action is derived from the wrong state;
change the label computation in useToggleListsRevealedAction (the object with
property label) to use listsRevealed instead of subject.alignmentsRevealed so
the button reflects the actual toggle state (i.e., label: listsRevealed ? 'Hide
Lists' : 'Reveal Lists'), and ensure any surrounding logic that sets or reads
listsRevealed remains consistent with the toggle handler.
ℹ️ Review info
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
convex/_generated/api.d.tsis excluded by!**/_generated/**
📒 Files selected for processing (7)
convex/_model/tournaments/_helpers/getAvailableActions.tsconvex/_model/tournaments/index.tsconvex/_model/tournaments/mutations/toggleTournamentListsRevealed.tsconvex/tournaments.tssrc/components/TournamentProvider/actions/useToggleAlignmentsRevealedAction.tssrc/components/TournamentProvider/actions/useToggleListsRevealedAction.tssrc/services/tournaments.ts
src/components/TournamentProvider/actions/useToggleListsRevealedAction.ts
Outdated
Show resolved
Hide resolved
…edAction.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Resolves: #306