Skip to content

improve serialization stability#37

Open
Deweh wants to merge 1 commit intoianpatt:masterfrom
Deweh:fix-serialization
Open

improve serialization stability#37
Deweh wants to merge 1 commit intoianpatt:masterfrom
Deweh:fix-serialization

Conversation

@Deweh
Copy link
Contributor

@Deweh Deweh commented Aug 23, 2024

This PR adds a few extra safety mechanisms to the serialization system to improve stability:

  • IDRemapDeleteListener is now only kept registered during LoadGame.
  • Added two mutexes, one for changedIDs and one for deletedIDs, plus applicable lock guards.
  • Added an atomic bool that keeps track of whether IDRemapDeleteListener is currently registered.

@ianpatt
Copy link
Owner

ianpatt commented Aug 24, 2024

I'm going to need to verify this via reverse engineering the related code myself before turning this back on. The changes here make sense, but anything save-related is critical. This probably means a reasonably lengthy delay given my current workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants