Refactor audit timeline styles and layout#2
Open
EG-Mohamed wants to merge 1 commit intoianzcreative:mainfrom
Open
Refactor audit timeline styles and layout#2EG-Mohamed wants to merge 1 commit intoianzcreative:mainfrom
EG-Mohamed wants to merge 1 commit intoianzcreative:mainfrom
Conversation
Refactor styles and structure of audit timeline component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
history-modal.blade.phpview to improve maintainability, accessibility, and dark mode support. The main changes include moving inline CSS custom properties into a<style>block, introducing new CSS classes for event types and value changes (with dark mode styles), and enhancing RTL (right-to-left) language support.Styling and Maintainability Improvements:
.audit-timelinefrom an inlinestyleattribute into a dedicated<style>block for better maintainability and separation of concerns.leftwith logical properties likeinset-inline-startfor.audit-timeline, timeline markers, and arrow icons, improving RTL support. [1] [2] [3] [4]Dark Mode and Accessibility Enhancements:
.audit-event-created,.audit-event-deleted,.audit-event-updated) and value changes (.audit-old-value,.audit-new-value), with specific dark mode styles to improve readability and accessibility in dark themes.RTL Language Support:
These changes collectively make the audit history modal more maintainable, visually consistent, and accessible across different themes and text directions.