Skip to content

Enhanced exception for createContent #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: 4.6
Choose a base branch
from
Draft

Enhanced exception for createContent #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b2968e
Enhanced exception for createContent
reithor Oct 28, 2025
8120122
adapt error message
reithor Oct 28, 2025
a788be6
fix-cs
reithor Oct 28, 2025
68f1e90
testCreateContent: Changed expected message
reithor Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/Repository/ContentService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ public function createContent(APIContentCreateStruct $contentCreateStruct, array
);

if (!empty($errors)) {
throw new ContentFieldValidationException($errors);
throw ContentFieldValidationException::createNewWithMultiline($errors);
}

$spiLocationCreateStructs = $this->buildSPILocationCreateStructs(
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/Repository/Service/Mock/ContentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2503,7 +2503,7 @@ public function providerForTestCreateContentThrowsContentFieldValidationExceptio
public function testCreateContentThrowsContentFieldValidationException($mainLanguageCode, $structFields): void
{
$this->expectException(ContentFieldValidationException::class);
$this->expectExceptionMessage('Content fields did not validate');
$this->expectExceptionMessage('Content "" fields did not validate');
Copy link
Member

@alongosz alongosz Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is concerning. Is there no content name at this stage due to business logic or mocking?

Side note: this code is most likely a result of few automated refactoring. If you're touching this, both expectException and expectExceptionMessage should be moved right before the statement which produces the exception.

Copy link
Contributor Author

@reithor reithor Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, what are the implications for the UI? Meaning how does this show up in the interface?

I don't think it is shown in the UI at all.
Error is thrown when creating content

# [src/lib/Repository/ContentService->createContent()

        $errors = $this->validate(
            $contentCreateStruct,
            [],
            $fieldIdentifiersToValidate
        );

        if (!empty($errors)) {
-            throw new ContentFieldValidationException($errors);
+           throw ContentFieldValidationException::createNewWithMultiline($errors);
        }

At this stage we only have $contentCreateStruct - nothing is persisted - we do not have a ContentName yet.

Copy link
Contributor Author

@reithor reithor Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I see the BC concerns.


$fieldDefinitions = $this->fixturesForTestCreateContentNonRedundantFieldSetComplex();
list($contentCreateStruct, $allFieldErrors) =
Expand Down
Loading