IBX-10507: Allowed nullable type declarations for method parameters across the codebase #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
ViniTou,
barw4,
konradoboza and
tbialcz
and removed request for
a team
konradoboza
approved these changes
Sep 17, 2025
konradoboza
reviewed
Sep 17, 2025
konradoboza
approved these changes
Sep 17, 2025
ViniTou
reviewed
Sep 23, 2025
phpstan-baseline.neon
Outdated
| - | ||
| message: '#^Method Ibexa\\Rest\\Input\\Handler\\Xml\:\:convertDom\(\) should return array but returns null\.$#' | ||
| identifier: return.type | ||
| message: '#^Method Ibexa\\Rest\\Input\\Handler\\Xml\:\:convertDom\(\) return type has no value type specified in iterable type array\.$#' |
There was a problem hiding this comment.
it should be easy to fix those two, even with mixed.
phpstan-baseline.neon
Outdated
| - | ||
| message: '#^Method Ibexa\\Rest\\Input\\Handler\\Xml\:\:convert\(\) return type has no value type specified in iterable type array\.$#' | ||
| identifier: missingType.iterableValue | ||
| message: '#^Cannot assign new offset to array\|string\.$#' |
There was a problem hiding this comment.
this should be also easly fixed with is_array check.
added 5 commits
September 23, 2025 14:20
wiewiurdp
force-pushed
the
IBX-10507-fixing-implicitly-nullable-parameters
branch
from
7d4beb3 to
7a07225
Compare
|
tbialcz
approved these changes
Sep 24, 2025
barw4
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allowed nullable type declarations for method parameters across the codebase